Skip to content

Conversation

@juherr
Copy link
Contributor

@juherr juherr commented Nov 5, 2021

Fix #28538

@pivotal-cla
Copy link

@juherr Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@juherr Thank you for signing the Contributor License Agreement!

@juherr juherr changed the title Upgrade to Embedded Mongo 3.0.0 Upgrade to Embedded Mongo 3.2.0 Nov 5, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 5, 2021
@juherr juherr force-pushed the bugfix/github-28538 branch from 473d31d to 99084a1 Compare November 5, 2021 18:08

@Test
void customFeatures() {
EnumSet<Feature> features = EnumSet.of(Feature.TEXT_SEARCH, Feature.SYNC_DELAY, Feature.ONLY_WITH_SSL,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ONLY_WITH_SSL and ONLY_WINDOWS_2008_SERVER features were dropped with 3.2.0: flapdoodle-oss/de.flapdoodle.embed.mongo@3d3c0de

@snicoll snicoll added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 8, 2021
@snicoll snicoll added this to the 2.7.x milestone Nov 8, 2021
@juherr
Copy link
Contributor Author

juherr commented Nov 8, 2021

For the record, as a workaround, it is possible to force the embedded-mongo.version and override the bean definition in a configuration:

		@Bean
		RuntimeConfig embeddedMongoRuntimeConfig(
				ObjectProvider<DownloadConfigBuilderCustomizer> downloadConfigBuilderCustomizers) {
			Logger logger = LoggerFactory.getLogger(getClass().getPackage().getName() + ".EmbeddedMongo");
			ProcessOutput processOutput = ProcessOutput.builder()
					.output(Processors.logTo(logger, Slf4jLevel.INFO))
					.error(Processors.logTo(logger, Slf4jLevel.ERROR))
					.commands(Processors.named("[console>]", Processors.logTo(logger, Slf4jLevel.DEBUG)))
					.build();
			return Defaults.runtimeConfigFor(Command.MongoD, logger).processOutput(processOutput)
					.artifactStore(getArtifactStore(logger, downloadConfigBuilderCustomizers.orderedStream()))
					.isDaemonProcess(false).build();
		}

		private ExtractedArtifactStore getArtifactStore(Logger logger,
				Stream<DownloadConfigBuilderCustomizer> downloadConfigBuilderCustomizers) {
			ImmutableDownloadConfig.Builder downloadConfigBuilder = Defaults.downloadConfigFor(Command.MongoD);
			downloadConfigBuilder.progressListener(new Slf4jProgressListener(logger));
			downloadConfigBuilderCustomizers.forEach((customizer) -> customizer.customize(downloadConfigBuilder));
			DownloadConfig downloadConfig = downloadConfigBuilder.build();
			return Defaults.extractedArtifactStoreFor(Command.MongoD).withDownloadConfig(downloadConfig);
		}

@philwebb philwebb force-pushed the main branch 3 times, most recently from 1ca278f to 902dd0b Compare November 19, 2021 20:17
@snicoll snicoll changed the title Upgrade to Embedded Mongo 3.2.0 Upgrade to Embedded Mongo 3.2.5 Jan 3, 2022
@snicoll snicoll self-assigned this Jan 3, 2022
snicoll pushed a commit that referenced this pull request Jan 4, 2022
snicoll added a commit that referenced this pull request Jan 4, 2022
@snicoll snicoll closed this in 6d55b68 Jan 4, 2022
@snicoll snicoll modified the milestones: 2.7.x, 2.7.0-M1 Jan 4, 2022
@snicoll
Copy link
Member

snicoll commented Jan 4, 2022

@juherr thank you for making your first contribution to Spring Boot.

@juherr juherr deleted the bugfix/github-28538 branch January 4, 2022 11:06
@snicoll snicoll added status: superseded An issue that has been superseded by another type: task A general task and removed type: dependency-upgrade A dependency upgrade labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: superseded An issue that has been superseded by another type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedded Mongo Autoconfiguration does not work with flapdoodle.embed.mongo > 3.0.0

4 participants