Skip to content

Conversation

@polarbear567
Copy link
Contributor

Polish in some modules.

izeye and others added 30 commits September 27, 2019 19:52
* pr/18383:
  Mention Java 13 in system requirements docs

Closes spring-projectsgh-18383
* pr/18384:
  Polish some external documentation links

Closes spring-projectsgh-18384
Replace `{vbar}` with an escaped pipe character. Unfortunately
`{vbar}` does not render correctly with PDF generation.

See spring-projectsgh-18374
* pr/18374:
  Simplify pipe escaping for reference doc tables
  Avoid need to escape pipe character in reference tables

Closes spring-projectsgh-18374
Add an appication context initializer to detect and store the
active RSocket port in the Environment under
`local.rsocket.server.port`.

Additionally add a `@LocalServerPort` that provides a convenient
alternative to `@Value`.

See spring-projectsgh-18287

Co-authored-by: Eddú Meléndez <eddu.melendez@gmail.com>
* pr/18287:
  Polish 'Add @LocalRSocketServerPort support'
  Add @LocalRSocketServerPort support

Closes spring-projectsgh-18287
Polish code and relocate `RSocketServerBootstrap` from `server` to
`context` since it's really an `ApplicationContext` concern.

Closes spring-projectsgh-18391
Fix a package tangle that was introduced when we added cache bypass to
`SpringIterableConfigurationPropertySource`. Ideally we should have
been able to depend on `env` from `context` but unfortunately the
`EnvironmentPostProcessor` interface references `SpringApplication`
which needs to use the Binder.

The `isImmutable` method has now been moved to `OriginLookup` which
removes the immediate tangle.

Closes spring-projectsgh-18393
Fix package tangle in devtools by relocating `DevToolsEnablementDeducer`
to a new `system` package.

Closes spring-projectsgh-18393
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 2, 2021
@snicoll snicoll removed the status: waiting-for-triage An issue we've not yet triaged label Nov 2, 2021
@snicoll snicoll self-assigned this Nov 2, 2021
@snicoll snicoll added this to the 2.6.0 milestone Nov 2, 2021
@snicoll snicoll added the type: task A general task label Nov 2, 2021
@snicoll
Copy link
Member

snicoll commented Nov 2, 2021

@polarbear567 thanks for the PR. Would you please make sure your branch is up to date with main before contributing? This PR has 58 unrelated commits. I've polished them but if you'd be great if the PR only contained the intended changes.

snicoll added a commit that referenced this pull request Nov 2, 2021
snicoll pushed a commit that referenced this pull request Nov 2, 2021
@snicoll snicoll closed this in 942096b Nov 2, 2021
@polarbear567
Copy link
Contributor Author

@polarbear567 thanks for the PR. Would you please make sure your branch is up to date with main before contributing? This PR has 58 unrelated commits. I've polished them but if you'd be great if the PR only contained the intended changes.

Sure. In fact, I'll update the latest code every time. It seems that there is no problem manually before, but recently I have used the fetch upstream function provided by the GitHub page. It seems that this problem has occurred. I'm not sure, but next time I will switch back to manually updating the latest code. Finally, thanks for the reminder.

@polarbear567 polarbear567 deleted the leo/polishsomeerrors branch November 23, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants