Skip to content

Switch to Adoptium JDK builds in CI #27539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dreis2211
Copy link
Contributor

Hi,

this PR switches the AdoptOpenJDK builds over to the new Adoptium builds. The side-effect of this are updated versions as the previous equivalents are not available anymore.

For completeness reasons, I should also mention that the previous JDK 17 build didn't include JEP 403 yet, because apparently AdoptOpenJDK didn't update things for quite a while anymore. My local tests used always the latest OpenJDK builds (30 or 32) with JEP 403 included and were successful, so I'm hopeful CI will be as well. But you never know.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 1, 2021
@dreis2211
Copy link
Contributor Author

dreis2211 commented Aug 5, 2021

The AdoptOpenJDK will shortly redirect to the newest Adoptium builds. Hence the CI created all tickets for JDK 8 - 17 already in the meantime. I guess this leaves this PR only with the update to JDK 17 from Adoptium and the API switch

@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 5, 2021
@snicoll snicoll added this to the 2.4.10 milestone Aug 5, 2021
@snicoll snicoll self-assigned this Aug 5, 2021
@snicoll snicoll modified the milestones: 2.4.10, 2.3.13 Aug 5, 2021
@snicoll
Copy link
Member

snicoll commented Aug 5, 2021

It didn't create them for JDK 17, which surprised me a bit. I'll rebase what's left on 2.3.x onward. Thanks again Christoph!

@dreis2211
Copy link
Contributor Author

@snicoll Thanks. I just noticed that I wrote JDK 8-17, but in fact it is JDK 8-16. The JDK 17 stuff is just not redirected to the Adoptium builds when accessing the AdoptOpenJDK API, so the update detection job didn't notice any change.

@snicoll
Copy link
Member

snicoll commented Aug 5, 2021

It doesn't work for JDK 15 either (whereas the old api does). It's not big deal for that one but we won't pick up new JDK 17 build if we merge this as far as I understand?

@dreis2211
Copy link
Contributor Author

dreis2211 commented Aug 5, 2021

Why would it not pick up new builds for JDK 17 once new builds are available? Well, apart from being on the latest available build after merging the PR (at the time of writing this). Or did I get your question wrong, @snicoll ?

@snicoll
Copy link
Member

snicoll commented Aug 5, 2021

Sorry, I was using the ga url against 17, that's not going to work very well. All good, sorry for the noise.

snicoll pushed a commit that referenced this pull request Aug 6, 2021
@snicoll snicoll closed this in 7cec0b3 Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants