Skip to content

Conversation

dreis2211
Copy link
Contributor

Hi,

I just noticed that OutputCaptureRuleTests were not running due to the fact that they need to be run with JUnit4. This PR is an attempt to fix this.

Let me know if there's maybe a smarter way to achieve this in Gradle.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 20, 2020
@dreis2211
Copy link
Contributor Author

Test failure seems to be our infamous loader constraint violation.

@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 21, 2020
@philwebb philwebb added this to the 2.3.x milestone Jan 21, 2020
@snicoll snicoll self-assigned this Jan 21, 2020
@snicoll snicoll modified the milestones: 2.3.x, 2.3.0.M1 Jan 21, 2020
snicoll pushed a commit that referenced this pull request Jan 21, 2020
@snicoll snicoll closed this in 308d9ba Jan 21, 2020
@sbrannen
Copy link
Member

sbrannen commented Feb 4, 2020

I realize this PR has been closed, but unless I'm missing something you should be able to remove useJUnit() since useJUnitPlatform() will result in the Vintage test engine running on the JUnit Platform.

TBH, I'm not even sure what happens behind the scenes if you declare both useJUnit() and useJUnitPlatform() in the same test task -- maybe JUnit 4 tests are executed twice.

@dreis2211
Copy link
Contributor Author

@sbrannen Good catch. It's not needed, but it doesn't seem to execute it twice either. Anyway, I've opened #20035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants