Dependency management for Kafka is incomplete #16728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This jar is now a dependency of spring-kafka-test which is added in test scope by initializr. See spring-projects/spring-kafka#1084
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
|
That feels a candidate to |
|
+1 for adding this in 2.1.x. I think we should review the other entries and see what else is missing too. |
snicoll
changed the title
snicoll
added
type: bug
wilkinsona
changed the title
|
Minus a few examples projects, we're missing dependency management for the following modules:
|
wilkinsona
pushed a commit
that referenced
this pull request
May 8, 2019
wilkinsona
added a commit
that referenced
this pull request
May 8, 2019
|
Thank you, @garyrussell. The proposed addition to the dependency management is now in 2.1.x and master along with the other missing modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This jar is now a dependency of spring-kafka-test which is added in
test scope by initializr.
See spring-projects/spring-kafka#1084