Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove destroyMethod attribute in @Bean for MeterRegistry #12725

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public String get(String k) {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public AtlasMeterRegistry customRegistry(AtlasConfig config, Clock clock) {
return new AtlasMeterRegistry(config, clock);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public String get(String k) {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public DatadogMeterRegistry customRegistry(DatadogConfig config, Clock clock) {
return new DatadogMeterRegistry(config, clock);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public String get(String k) {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public GangliaMeterRegistry customRegistry(GangliaConfig config, Clock clock) {
return new GangliaMeterRegistry(config, clock);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public String get(String k) {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public GraphiteMeterRegistry customRegistry(GraphiteConfig config, Clock clock) {
return new GraphiteMeterRegistry(config, clock);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public String get(String k) {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public InfluxMeterRegistry customRegistry(InfluxConfig config, Clock clock) {
return new InfluxMeterRegistry(config, clock);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public String get(String k) {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public JmxMeterRegistry customRegistry(JmxConfig config, Clock clock) {
return new JmxMeterRegistry(config, clock);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public String get(String k) {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public NewRelicMeterRegistry customRegistry(NewRelicConfig config, Clock clock) {
return new NewRelicMeterRegistry(config, clock);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public String get(String k) {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public SignalFxMeterRegistry customRegistry(SignalFxConfig config, Clock clock) {
return new SignalFxMeterRegistry(config, clock);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public String get(String k) {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public StatsdMeterRegistry customRegistry(StatsdConfig config, Clock clock) {
return new StatsdMeterRegistry(config, clock);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public String uri() {
@Import(BaseConfiguration.class)
static class CustomRegistryConfiguration {

@Bean(destroyMethod = "stop")
@Bean
public WavefrontMeterRegistry customRegistry(WavefrontConfig config,
Clock clock) {
return new WavefrontMeterRegistry(config, clock);
Expand Down