Multiple @ServletComponentScan with no base packages may cause startup to fail with an UnsupportedOperationException #12715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description When a project contains multiple `@ServletComponentScan` annotated class in classpath, and at least one annotation don't explicitly specify `basePackages` and `basePackageClass` attribute, the application MAY fail on startup, caused by UnsupportedOperationException: <pre> java.lang.UnsupportedOperationException: null at java.util.AbstractCollection.add(AbstractCollection.java:262) at java.util.AbstractCollection.addAll(AbstractCollection.java:344) at org.springframework.boot.web.servlet.ServletComponentScanRegistrar.updatePostProcessor(ServletComponentScanRegistrar.java:62) at org.springframework.boot.web.servlet.ServletComponentScanRegistrar.registerBeanDefinitions(ServletComponentScanRegistrar.java:48) ... </pre> # Reproduction There is a single class application to reproduce this bug just for demostration. <pre> @SpringBootApplication public class SpringBootTest1 { public static void main(String[] args) { SpringApplication.run(SpringBootTest1.class, args); } @ServletComponentScan public static class Config1 { } @ServletComponentScan public static class Config2 { } } </pre>
spring-projects-issues
added
the
status: waiting-for-triage
vivimice
changed the title
philwebb
added
for: merge-with-amendments
|
We should ideally add a unit test for this. |
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Apr 3, 2018
Previously, when a project contained multiple `@ServletComponentScan` annotated classes in classpath, and at least one annotation don't explicitly specify `basePackages` and `basePackageClass` attribute, the application could fail to start with an UnsupportedOperationException. The failure occurred due to the creating of an unmodifiable set when no base packages are configured and a subsequent attempt to add base packages to that sit. This commit fixes the issue by removing the use of an unmodifiable set when `@ServletComponentScan` with no base packages in processed before any other `@ServletComponentScan` annotations. See gh-12715
wilkinsona
added a commit
that referenced
this pull request
Apr 3, 2018
* gh-12715: Polish "Use modifiable set for @ServletComponentScan with no packages" Use modifiable set for @ServletComponentScan with no packages
|
@vivimice Thank you very much for making your first contribution to Spring Boot. This fix that you proposed is now in 1.5.x and master. I added some tests in this polishing commit. |
|
@wilkinsona My pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12714
Description
When a project contains multiple
@ServletComponentScanannotated class in classpath, and at least one annotation don't explicitly specifybasePackagesandbasePackageClassattribute, the application MAYfail on startup, caused by UnsupportedOperationException:
Reproduction
There is a single class application to reproduce this bug just for demostration.
@SpringBootApplication public class SpringBootTest1 { public static void main(String[] args) { SpringApplication.run(SpringBootTest1.class, args); } @ServletComponentScan public static class Config1 { } @ServletComponentScan public static class Config2 { } }