Skip to content

Fix references to management related properties #11091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Nov 21, 2017

There are quite a few places where references to endpoints.* properties haven't been updated to management.endpoint[s].* introduced in #10176.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 21, 2017
@snicoll snicoll added priority: high type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 21, 2017
@snicoll snicoll added this to the 2.0.0.M7 milestone Nov 21, 2017
@snicoll snicoll self-assigned this Nov 21, 2017
@@ -37,7 +37,7 @@
*
* @author Andy Wilkinson
*/
@TestPropertySource(properties = "endpoints.shutdown.enabled=true")
@TestPropertySource(properties = "management.endpoint.shutdown.enabled=true")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's redundant and can be removed entirely.

snicoll pushed a commit that referenced this pull request Nov 23, 2017
@snicoll snicoll closed this in dfc0e39 Nov 23, 2017
snicoll added a commit that referenced this pull request Nov 23, 2017
* pr/11091:
  Polish "Fix references to management related properties"
  Fix references to management related properties
@snicoll
Copy link
Member

snicoll commented Nov 23, 2017

Thanks @vpavic, I went ahead and changed the samples to expose everything instead (that was the original intention with management.security.enabled=false in 1.5.x anyway)

@vpavic vpavic deleted the endpoint-props branch November 23, 2017 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants