Environment variable not bound

[jgoelen]

Since Spring Boot v1.2.6.RELEASE the binding of environment variables behaves differently.
The properties of a class with an @ConfigurationProperties annotation are not set when combining a YAML file and OS environment variables. The following github repo contains a unit test to reproduce the problem:

https://github.com/jgoelen/spring-boot-env-bug

The test works fine with version 1.2.5.RELEASE (repo tag v1.2.5.RELEASE)

[philwebb]

@jgoelen How do I get the tests to fail? Checkout master and mvn clean package seems to work fine for me.

[philwebb]

Wait, never mind. Master was also on 1.2.5.RELEASE. Upgraded the POM and it failed.

[philwebb]

I bit of git bisect seems to show 1abd087 is the culprit.

[philwebb]

See #3385

[philwebb]

Unit test to replicate in PropertiesConfigurationFactoryTests:

    @Test
    public void testBindWithDashPrefix() throws Exception {
        // gh-4045
        this.targetName = "foo-bar";
        MutablePropertySources propertySources = new MutablePropertySources();
        propertySources.addLast(new SystemEnvironmentPropertySource("systemEnvironment",
                Collections.<String, Object>singletonMap("FOO_BAR_NAME", "blah")));
        propertySources.addLast(new RandomValuePropertySource("random"));
        setupFactory();
        this.factory.setPropertySources(propertySources);
        this.factory.afterPropertiesSet();
        Foo foo = this.factory.getObject();
        assertEquals("blah", foo.name);
    }

[philwebb]

This one turned out to be very hard to track down. Thanks for ruining my morning :)

If you have a chance should you try the 1.2.7.BUILD-SNAPSHOT version (once CI build BOOT-PUB3-125 finishes).

[jgoelen]

It works! Thanks for the fix.

[philwebb]

Thanks for testing.