Skip to content

Rename version property for Git Commit ID Maven plugin from git-commit-id-plugin.version to git-commit-id-maven-plugin.version #34397

Closed
@jcranfordupgrade

Description

@jcranfordupgrade

TLDR

Result is confusing mix of old and new artifactId versus version naming for this dependency in the effective pom.xml:

<plugin>
<groupId>io.github.git-commit-id</groupId>
<artifactId>git-commit-id-maven-plugin</artifactId>
<version>${git-commit-id-plugin.version}</version>
</plugin>

This is the build.gradle entry from Spring Boot Dependencies 3.0.3.

https://github.com/spring-projects/spring-boot/blob/v3.0.3/spring-boot-project/spring-boot-dependencies/build.gradle#L266-L272

	library("Git Commit ID Plugin", "5.0.0") {
		group("io.github.git-commit-id") {
			plugins = [
				"git-commit-id-maven-plugin"
			]
		}
	}

This is how the version property appears in the effective pom.xml. The property name does not match the above artifactId.

<git-commit-id-plugin.version>5.0.0</git-commit-id-plugin.version>

The version property is not directly defined in the repository, so I cannot submit a PR to fix it. There is no Gradle parent either, so Spring Boot Dependencies is not inheriting the property from somewhere else. I think maybe the effective pom.xml is generated programmatically by a generatePomFileForMavenPublication task, but I was not able to track down where that data is coming from.

Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions