Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ConfigFileApplicationListener and rework application properties support #22497

Closed
philwebb opened this issue Jul 22, 2020 · 0 comments
Closed

Replace ConfigFileApplicationListener and rework application properties support #22497

philwebb opened this issue Jul 22, 2020 · 0 comments
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
2.4.0-M2

Comments

@philwebb
Copy link
Member

There are quite a few issues arising from our current application.properties processing code that we'd like to fix. Specifically we'd like to address the following concerns:

  • Create distinct classes for different areas of functionality:
    • Calling EnvironmentPostProcessors
    • Adding the RandomPropertySource
    • Moving the defaultPropertySource to the end
    • Loading application.properties and application.yml files
  • Process config data files in phases, and stop profile specific files/documents from activating further profiles
  • Support custom imports so that we can support volume mounts
  • Provided a pluggable API that could make it possible for Spring Cloud to drop the need for bootstrap properties
  • Support activation conditions for documents such as on-cloud and on-profile
@philwebb philwebb self-assigned this Jul 22, 2020
This was referenced Jul 22, 2020
Closed
Closed
@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Jul 24, 2020
@wilkinsona wilkinsona mentioned this issue Jul 24, 2020
Closed
@wilkinsona wilkinsona added this to the 2.4.0-M2 milestone Jul 24, 2020
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review labels Jul 24, 2020
philwebb added a commit that referenced this issue Jul 27, 2020
@philwebb
Improve deprecated exception message
84bcd0e 
Update the exception message so that it includes the class name of the
implementation.

See gh-22497
philwebb added a commit that referenced this issue Aug 12, 2020
@philwebb
Fix spring.config.activate.on-profile metadata
bc3f028 
Fix the `spring.config.activate.on-profile` entry which was accidentally
entered as `spring.config.import.on-profile`.

See gh-22497
@encircled encircled mentioned this issue Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-M2
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona