Restore deprecated code with no replacement that Spring Cloud Hoxton needs

[spencergibb]

Spring Cloud Hoxton is trying to support both 2.2 and 2.3 simultaneously.

#19699 removed some deprecations which will cause problems.

So far the items I've found that do not have replacements are:

• org.springframework.boot.context.properties.ConfigurationBeanFactoryMetadata.
• org.springframework.boot.actuate.health.CompositeHealthIndicator
• org.springframework.boot.actuate.health.HealthAggregator

It was a smaller list than I initially feared. I'll double-check that those are all of them.

[scottfrederick]

Just going by deprecation comments:

• org.springframework.boot.context.properties.ConfigurationBeanFactoryMetadata was replaced by org.springframework.boot.context.properties.ConfigurationPropertiesBean
• org.springframework.boot.actuate.health.CompositeHealthIndicator was replaced by org.springframework.boot.actuate.health.CompositeHealthContributor
• org.springframework.boot.actuate.health.HealthAggregator was replaced by org.springframework.boot.actuate.health.StatusAggregator

Of course this doesn't mean that all the methods and features of the classes that were removed have replacements that work for Spring Cloud. If you can provide some details on how the removed classes are used, or which Spring Cloud projects use them, we can dig deeper and make sure you have what you need.

[spencergibb]

Sure. My term replacements wasn't probably the most descriptive. ConfigurationBeanFactoryMetadata is in a method signature and can't be removed on our side. I'll have to look at the health stuff in more detail to see if a Hoxton app can run with boot 2.3 without those.

[scottfrederick]

@spencergibb I'll look into restoring ConfigurationBeanFactoryMetadata first thing tomorrow.

[wilkinsona]

ConfigurationBeanFactoryMetadata is rather pointless in Boot 2.2. It no longer holds any state and just delegates straight onto the application context. I wonder if the logic could be moved to Cloud rather than leaving it in Boot's public API?

[spencergibb]

Having it missing breaks our build with 2.3