Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OutputCaptureRule to be used directly with AssertJ #17512

Closed
philwebb opened this issue Jul 14, 2019 · 2 comments
Closed

Allow OutputCaptureRule to be used directly with AssertJ #17512

philwebb opened this issue Jul 14, 2019 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

If we make OutputCaptureRule implement CapturedOutput it could be used directly with AssertJ.

@philwebb philwebb added the type: enhancement A general enhancement label Jul 14, 2019
@philwebb philwebb added this to the 2.2.x milestone Jul 14, 2019
@philwebb philwebb self-assigned this Jul 14, 2019
@dreis2211
Copy link
Contributor

dreis2211 commented Jul 14, 2019

@philwebb I think there is a chance that #17491 would make OutputCaptureRule obsolete as it wouldn't be used anymore - apart from its own tests. At least the internal one under org.springframework.boot.testsupport.system could be removed. Not sure about the one under org.springframework.boot.test.system as I don't know what your JUnit 4 support plans are, but there should be no internal usages of it anymore as well once #17491 is merged.

Thought I better comment on this - maybe it saves you some work. If not, ignore me and my 0.5x developer thoughts :P

@philwebb
Copy link
Member Author

Thanks @dreis2211. We're going to continue to support JUnit4 externally for quite a while. The internal version is copy/paste at the moment but it'll be a good idea to delete it eventually.

@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.2.0.M5 Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants