JndiObjectFactoryBean not recognizing Datasource.class and unbinding on close

[miller79]

We are trying to use the JndiObjectFactoryBean to retrieve our Datasources following the pattern of the jee tag for Spring Boot and getting the following exception:

Caused by: org.springframework.beans.factory.BeanDefinitionStoreException: Factory method [public javax.sql.DataSource org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration$NonEmbeddedConfiguration.dataSource()] threw exception; nested exception is org.springframework.beans.factory.BeanCreationException: Cannot determine embedded database driver class for database type NONE. If you want an embedded database please put a supported one on the classpath.
    at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:188)
    at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:586)
    ... 274 common frames omitted
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)Caused by: org.springframework.beans.factory.BeanCreationException: Cannot determine embedded database driver class for database type NONE. If you want an embedded database please put a supported one on the classpath.
    at org.springframework.boot.autoconfigure.jdbc.DataSourceProperties.getDriverClassName(DataSourceProperties.java:93)
    at org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration$NonEmbeddedConfiguration.dataSource(DataSourceAutoConfiguration.java:105)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

The following code works fine:

@Bean(destroyMethod = "")
    public DataSource dataSource() {
        return (DataSource) new JndiObjectFactoryBean() {{
            setExpectedType(DataSource.class);
            setResourceRef(true);
            setJndiName("jndiDatasource");

            try {
                afterPropertiesSet();
            } catch (Exception e) {
                e.printStackTrace();
            }

        }}.getObject();
    }

But the code below throws the exception above:

@Bean
    public JndiObjectFactoryBean dataSource() {
        return new JndiObjectFactoryBean() {{
            setExpectedType(DataSource.class);
            setResourceRef(true);
            setJndiName("jndiDatasource");
        }};
    }

From looking at the source a bit, it would seem that the @ConditionalOnMissingBean does not also check the FactoryBean return type. We also tried using the jee tag within the XML and including that but it still gave the error above. This looks similar to #352 and #355 but wanted to report this. We are running in Weblogic 12c and had to add the destroyMethod="" as without it it was unbinding the Datasource on undeploy.

[snicoll]

Can you try with 1.2.0.M1 because this has explicit support for JNDI data source.

[philwebb]

Just to provide a bit more background. It's currently quite difficult for the @ConditionalOnMissingBean to detect the type that a FactoryBean will create without causing early instantiation. There isn't really an easy way to solve the problem.

One option you could try with 1.1 is to declare the factory bean with a generic. We can inspect the method signature and use it to deduce the type that will be created. e.g.:

@Bean
public FactoryBean<DataSource> dataSource() {
    // ....
}

[miller79]

We just tried 1.2.0.M1 using the YAML properties and it does work however it has the same issue of unbinding the Datasource when it is closed.

After looking at how the code is being called, I believe its because it is using the Datasource as the bean which Spring is trying to shutdown. This is the same reason we had to add the destroyMethod="" in our code

@Bean
    @ConditionalOnMissingBean
    public DataSource dataSource(DataSourceProperties properties) {
        JndiDataSourceLookup dataSourceLookup = new JndiDataSourceLookup();
        return dataSourceLookup.getDataSource(properties.getJndiName());
    }

We also tried the approach of using the FactoryBean<DataSource> and we get the same error message I showed above.

I do like the new approach for using the YAML file to configure the Datasource but it will need to have a configuration to prevent the unbinding of the Datasource or we will not be able to use it.

[philwebb]

Thanks for testing. I'll take a look at the close method issue for M2

[miller79]

Thanks for looking into this. Let me know if you have anything you would like us to test.

[zachariahyoung]

How does one up vote this issue. I had the same issue here
http://stackoverflow.com/questions/25149969/why-does-datasources-close-on-tomcat-7-undeploy-with-spring-boot

[philwebb]

@zachariahyoung GitHub issues doesn't support voting, but the comment that you added is enough. Thanks!