Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider auto-configuration of HierarchicalNameMapper #12676

Closed
snicoll opened this issue Mar 29, 2018 · 1 comment
Closed

Reconsider auto-configuration of HierarchicalNameMapper #12676

snicoll opened this issue Mar 29, 2018 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@snicoll
Copy link
Member

snicoll commented Mar 29, 2018

See #12557 (comment)

HierarchicalNameMapper is not a component that can be shared amongst multiple monitoring systems. Right now the auto-configuration for Ganglia, Graphite, JMX and Statsd all create an instance if none exists in the context.

Rather that adapting to the presence of such a bean in the context, we should probably go with whatever makes sense and offer another way to customize the mapper. The simplest would be to require the user to override the registry.

ping @jkschneider
@snicoll snicoll added type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review labels Mar 29, 2018
@snicoll snicoll mentioned this issue Mar 29, 2018
Closed
@jkschneider jkschneider mentioned this issue Mar 29, 2018
Closed
@snicoll
Copy link
Member Author

snicoll commented Mar 29, 2018

Closing in favour of PR #12683

@snicoll snicoll closed this as completed Mar 29, 2018
@snicoll snicoll added status: duplicate A duplicate of another issue and removed for: team-attention An issue we'd like other members of the team to review type: enhancement A general enhancement labels Mar 29, 2018
snicoll added a commit that referenced this issue Apr 3, 2018
@snicoll
Merge pull request #12683 from jkschneider:gh-12676
5bf4a5f 
* pr/12683:
  Polish "Remove HierarchicalNameMapper as a configured @bean"
  Remove HierarchicalNameMapper as a configured @bean
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed status: duplicate A duplicate of another issue labels Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snicoll @philwebb