Skip to content

Commit

Permalink
Increase timeouts in ZipkinWebClientSenderTests
Browse files Browse the repository at this point in the history
This is an attempt to stabilize the tests. They are currently flaky
due to a timeout that appears to occur because the mock web server isn't
responding quickly enough. A larger timeout will either confirm this if
the tests stabilize or indicate that the problem has a different cause
if they do not stabilize.

Closes gh-42375
  • Loading branch information
wilkinsona committed Sep 19, 2024
1 parent 319e33f commit 0aeea6f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void onError(Throwable t) {
callbackResult.set(new CallbackResult(false, t));
}
});
return Awaitility.await().atMost(Duration.ofSeconds(5)).until(callbackResult::get, Objects::nonNull);
return Awaitility.await().atMost(Duration.ofMinutes(1)).until(callbackResult::get, Objects::nonNull);
}

protected void makeSyncRequest(List<byte[]> encodedSpans) throws IOException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ void beforeEach() {

@Override
Sender createSender() {
return createSender(Duration.ofSeconds(10));
return createSender(Duration.ofMinutes(1));
}

Sender createSender(Duration timeout) {
Expand Down

0 comments on commit 0aeea6f

Please sign in to comment.