Fix MongoJobInstanceDao to comply with JobInstanceDao contract#5275
Open
combe4259 wants to merge 1 commit intospring-projects:mainfrom
Open
Fix MongoJobInstanceDao to comply with JobInstanceDao contract#5275combe4259 wants to merge 1 commit intospring-projects:mainfrom
combe4259 wants to merge 1 commit intospring-projects:mainfrom
Conversation
Use findDistinct() with sorting in getJobNames() to return deduplicated and alphabetically sorted names, consistent with the JDBC implementation and the JobInstanceDao interface contract. Use MongoDB skip() and limit() in getJobInstances() to delegate pagination to the database instead of performing it in memory. Closes spring-projectsgh-5274 Signed-off-by: combe4259 <combe4259@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-5274
MongoJobInstanceDaohas two issues:getJobNames()usesfindAll()which loads all documents into memory without deduplication or sorting. TheJobInstanceDaointerface contract requires distinct, alphabetically sorted names. Replaced withfindDistinct()with sorting.getJobInstances()fetches all matching documents and paginates in Java. Replaced with MongoDBskip()andlimit().