Update RegisteredClient.Builder to use getters #451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Since the class is not final, it is possible to extend it. Because the Builder was directly accessing the properties rather than using the getters, it was not possible to use the .from(id) constructor in the extended class.
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
added
type: enhancement
Collaborator
|
Thanks for the PR @sarahmcalear ! This is now in main. |
doba16
pushed a commit
to doba16/spring-authorization-server
that referenced
this pull request
Apr 21, 2023
- Since the class is not final, it is possible to extend it. Because the Builder was directly accessing the properties rather than using the getters, it was not possible to use the .from(id) constructor in the extended class. Closes spring-projectsgh-451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the class is not final, it is possible to extend it. Because the Builder was directly accessing the properties rather than using the getters/setters, it was not possible to use the
.from(RegisteredClient)constructor in the extended class. This should enable extensions to use it.