authenticationDetailsSource of OAuth2TokenEndpointFilter should be customizable #448
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi @octopusthu, is this PR ready for review? Or are you still working on it? |
|
Hi @sjohnr , yes the PR is ready for review :) |
sjohnr
left a comment
sjohnr
left a comment
There was a problem hiding this comment.
Thanks for the PR @octopusthu. Please see suggestions below. When finished, please squash any new commits and edit the commit message to something like:
Customize authenticationDetailsSource of OAuth2TokenEndpointFilter
Closes gh-431
| */ | ||
| public final class OAuth2TokenEndpointConfigurer extends AbstractOAuth2Configurer { | ||
| private RequestMatcher requestMatcher; | ||
| private AuthenticationDetailsSource<HttpServletRequest, ?> authenticationDetailsSource; |
There was a problem hiding this comment.
For now, I think we should leave this out of the configurer, as it doesn't seem like most applications will need to customize this. Instead, if you want to set the filter's authenticationDetailsSource, you can do so by registering an ObjectPostProcessor<OAuth2TokenEndpointFilter>.
As always, we can continue to listen to feedback and if many are looking to customize this, we can revisit adding it into the configurer.
| JWKSet jwkSet = new JWKSet(TestJwks.DEFAULT_RSA_JWK); | ||
| jwkSource = (jwkSelector, securityContext) -> jwkSelector.select(jwkSet); | ||
| jwtCustomizer = mock(OAuth2TokenCustomizer.class); | ||
| authenticationDetailsSource=mock(AuthenticationDetailsSource.class); |
There was a problem hiding this comment.
Given the above recommendation, I believe this could be removed from this test.
sjohnr
added
status: duplicate
|
Thanks for the review @sjohnr ! The requested changes have been made and the commits squashed. Now the PR is ready for another review :) |
|
Thanks @octopusthu, this is now in |
4 participants
authenticationDetailsSourcefield ofOAuth2TokenEndpointFiltercustomizable by making it non-final and adding a setter.OAuth2TokenEndpointFilterTests, following the same way thatauthenticationConverter,authenticationSuccessHandlerandauthenticationFailureHandlerare tested.OAuth2TokenEndpointConfigurerto letauthenticationDetailsSourcecustomizable through the configurer.OAuth2ClientCredentialsGrantTests, mockauthenticationDetailsSourcethe same way thatauthenticationConverter,authenticationSuccessHandlerandauthenticationFailureHandlerare mocked.