Skip to content

Add update support in JdbcRegisteredClientRepository #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add update support in JdbcRegisteredClientRepository #365

wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Jul 22, 2021

Closes gh-356

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 22, 2021
@ghost
Copy link
Author

ghost commented Jul 22, 2021 •
edited by ghost
Loading

hi @jgrandja . Let me know if any of the RegisteredClient properties should be excluded from the update sql script.

@ghost ghost force-pushed the gh-356 branch from ecc8dfc to 73483cf Compare July 23, 2021 11:04
@jgrandja jgrandja self-assigned this Jul 28, 2021
@jgrandja jgrandja added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 28, 2021
@jgrandja jgrandja added this to the 0.2.0 milestone Jul 28, 2021
@jgrandja jgrandja added the status: duplicate A duplicate of another issue label Jul 28, 2021
jgrandja
jgrandja requested changes Jul 28, 2021
View reviewed changes
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ovidiupopa91 ! Please see review comments.

@jgrandja
Copy link
Collaborator

jgrandja commented Jul 28, 2021

@ovidiupopa91 I just realized that we need to hash client_secret on save(). You will notice that OAuth2ClientAuthenticationProvider uses a PasswordEncoder when matching on client_secret.

Do you have time / interest in adding JdbcRegisteredClientRepository.RegisteredClientParametersMapper.setPasswordEncoder() in a separate PR ?

@ghost
Copy link
Author

ghost commented Jul 28, 2021

@ovidiupopa91 I just realized that we need to hash client_secret on save(). You will notice that OAuth2ClientAuthenticationProvider uses a PasswordEncoder when matching on client_secret.

Do you have time / interest in adding JdbcRegisteredClientRepository.RegisteredClientParametersMapper.setPasswordEncoder() in a separate PR ?

Hi @jgrandja . Sure, I will do it.

@ghost ghost force-pushed the gh-356 branch from 73483cf to c6b83f6 Compare July 28, 2021 13:05
@ghost
Copy link
Author

ghost commented Jul 28, 2021

@jgrandja I've raised gh-378 for the other task.

@ghost ghost requested a review from jgrandja July 28, 2021 14:13
@jgrandja
Copy link
Collaborator

jgrandja commented Jul 29, 2021

Thanks for the updates @ovidiupopa91 ! This is now in main.

@jgrandja jgrandja closed this Jul 29, 2021
@ghost ghost deleted the gh-356 branch July 30, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrandja jgrandja Awaiting requested review from jgrandja

Assignees

@jgrandja jgrandja

Labels

status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

Add update support in JdbcRegisteredClientRepository

3 participants

@jgrandja @spring-projects-issues @ovidiupopa07