Add reusable default authentication failure handler #1384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
requested changes
Oct 13, 2023
Collaborator
jgrandja
left a comment
jgrandja
left a comment
There was a problem hiding this comment.
Thanks for the PR @ddubson!
Please see review comments.
Also, please update the Protocol Endpoints reference for the 4 specific endpoints where it states...
AuthenticationFailureHandler — An internal implementation that uses the OAuth2Error ...
After all the changes have been applied, please squash to 1 commit and ensure the commit message ends with:
Related gh-1369
Closes gh-1384
...rity/oauth2/server/authorization/web/authentication/DefaultAuthenticationFailureHandler.java
Outdated
Show resolved
Hide resolved
...rity/oauth2/server/authorization/web/authentication/DefaultAuthenticationFailureHandler.java
Outdated
Show resolved
Hide resolved
...rity/oauth2/server/authorization/web/authentication/DefaultAuthenticationFailureHandler.java
Outdated
Show resolved
Hide resolved
...rity/oauth2/server/authorization/web/authentication/DefaultAuthenticationFailureHandler.java
Outdated
Show resolved
Hide resolved
...rity/oauth2/server/authorization/web/authentication/DefaultAuthenticationFailureHandler.java
Outdated
Show resolved
Hide resolved
...amework/security/oauth2/server/authorization/web/OAuth2TokenIntrospectionEndpointFilter.java
Show resolved
Hide resolved
...gframework/security/oauth2/server/authorization/web/OAuth2TokenRevocationEndpointFilter.java
Show resolved
Hide resolved
...oauth2/server/authorization/web/authentication/DefaultAuthenticationFailureHandlerTests.java
Outdated
Show resolved
Hide resolved
...oauth2/server/authorization/web/authentication/DefaultAuthenticationFailureHandlerTests.java
Outdated
Show resolved
Hide resolved
...oauth2/server/authorization/web/authentication/DefaultAuthenticationFailureHandlerTests.java
Outdated
Show resolved
Hide resolved
jgrandja
added
type: enhancement
ddubson
force-pushed
the
issue-1369
branch
3 times, most recently
from
dcf80ef to
4016465
Compare
Contributor
Author
|
@jgrandja -- addressed the PR review issues. Let me know if there are anymore changes needed. |
Collaborator
|
Thanks for the updates @ddubson. This is now merged. FYI, I added a polish commit. Let me know if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses gh-1369