GH-5116: Fix openai default null tool arguments to empty JSON string#5232
Open
thisishwan2 wants to merge 3 commits intospring-projects:mainfrom
Open
GH-5116: Fix openai default null tool arguments to empty JSON string#5232thisishwan2 wants to merge 3 commits intospring-projects:mainfrom
thisishwan2 wants to merge 3 commits intospring-projects:mainfrom
Conversation
Signed-off-by: Pilhwan Choi <fill0006@naver.com>
Signed-off-by: Pilhwan Choi <fill0006@naver.com>
models/spring-ai-openai/src/test/java/org/springframework/ai/openai/api/OpenAiApiIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Pilhwan Choi <fill0006@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5116
Description
This PR fixes a compatibility issue with strict OpenAI-compatible models (e.g., Qwen) where tool_calls requests failed due to a missing function.arguments field.
Previously, when arguments was null, the field was omitted during serialization due to the @JsonInclude(Include.NON_NULL) annotation. While the official OpenAI API is lenient, strict providers reject this as invalid protocol usage, returning 400 Bad Request.
Changes
Updated the ChatCompletionFunction record in OpenAiApi by adding a compact constructor. This ensures that arguments defaults to "{}" (empty JSON object string) when null, guaranteeing the field is always present in the serialized JSON.
Verification
OpenAiApiT.javato verify that null arguments are correctly converted to "{}" and that the serialized JSON explicitly contains "arguments": "{}".