Make auto-configuration deps optional in testcontainers module #3465
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, spring-ai-spring-boot-testcontainers module brings auto-configuration modules plus other dependencies which are unnecessary. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
sunyuhan1998
approved these changes
Jun 7, 2025
spring-builds
pushed a commit
that referenced
this pull request
Jun 9, 2025
Currently, spring-ai-spring-boot-testcontainers module brings auto-configuration modules plus other dependencies which are unnecessary. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> (cherry picked from commit 161c437)
|
@eddumelendez Thanks for the PR and @sunyuhan1998 Thanks for the review. |
namsoo2
pushed a commit
to namsoo2/spring-ai
that referenced
this pull request
Jun 9, 2025
…g-projects#3465) Currently, spring-ai-spring-boot-testcontainers module brings auto-configuration modules plus other dependencies which are unnecessary. Auto-cherry-pick to 1.0.x Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> Signed-off-by: minsoo.nam <minsoo.nam@linecorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, spring-ai-spring-boot-testcontainers module brings
auto-configuration modules plus other dependencies which are unnecessary.
Signed-off-by: Eddú Meléndez eddu.melendez@gmail.com