-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add missing builders to Mistral models to follow project patterns #3464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🙌 Please fix the DCO check by signing your commit. |
Please update license header (
|
Please update the existing codes(include test code) that uses constructor to use Builder. |
Could you please avoid changing the import order unless necessary? It helps maintain consistency. |
In my personal opinion, it would be better to handle the "Fix Formatter |
@dev-jonghoonpark onn fix moved to #3477 |
Signed-off-by: Jason Smith <jasonparallel@gmail.com>
39ba067
to
27f0322
Compare
@dev-jonghoonpark Updated. Will github actions run all the IT with keys on the PR? |
@jasonparallel Good job. Let's wait for the maintainer's review. |
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
main
branch and squash your commits