fix:Typo cloud bindings #3436
Merged
fix:Typo cloud bindings #3436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix clou to cloud in docs Signed-off-by: chainHo <chainhou@gmail.com>
|
There is also a typo, |
sunyuhan1998
reviewed
Jun 4, 2025
OK. |
OK |
Signed-off-by: chainHo <chainhou@gmail.com>
Signed-off-by: chainHo <chainhou@gmail.com>
Signed-off-by: chainHo <chainhou@gmail.com>
| @@ -54,5 +54,5 @@ The following are the components for which the cloud binding support is currentl | |||
| | `weaviate` | `uri`, `api-key` | `spring.ai.vectorstore.weaviate.scheme`, `spring.ai.vectorstore.weaviate.host`, `spring.ai.vectorstore.weaviate.api-key` | |||
|
|
|||
| | `Tanzu GenAI` | |||
| | `genai` | `uri`, `api-key`, `model-capabilities` (`chat` and `embedding`), `model-name` | `spring.ai.openai.chat.base-url`, , spring.ai.openai.chat.api-key`, `spring.ai.openai.chat.options.model`, `spring.ai.openai.embedding.base-url`, , spring.ai.openai.embedding.api-key`, `spring.ai.openai.embedding.options.model` | |||
| | `genai` | `uri`, `api-key`, `model-capabilities` (`chat` and `embedding`), `model-name` | `spring.ai.openai.chat.base-url`, ,`spring.ai.openai.chat.api-key`, `spring.ai.openai.chat.options.model`, `spring.ai.openai.embedding.base-url`, ,`spring.ai.openai.embedding.api-key`, `spring.ai.openai.embedding.options.model` | |||
There was a problem hiding this comment.
Please fix the double commas (, ,)
Suggested change
| | `genai` | `uri`, `api-key`, `model-capabilities` (`chat` and `embedding`), `model-name` | `spring.ai.openai.chat.base-url`, ,`spring.ai.openai.chat.api-key`, `spring.ai.openai.chat.options.model`, `spring.ai.openai.embedding.base-url`, ,`spring.ai.openai.embedding.api-key`, `spring.ai.openai.embedding.options.model` | |
| | `genai` | `uri`, `api-key`, `model-capabilities` (`chat` and `embedding`), `model-name` | `spring.ai.openai.chat.base-url`, `spring.ai.openai.chat.api-key`, `spring.ai.openai.chat.options.model`, `spring.ai.openai.embedding.base-url`, `spring.ai.openai.embedding.api-key`, `spring.ai.openai.embedding.options.model` |
There was a problem hiding this comment.
yes, In the last commit , all the double comma was deleted. the password typo was correct now.
There was a problem hiding this comment.
Great work!
Now, let's wait for the maintainer's review.
Signed-off-by: chainHo <chainhou@gmail.com>
|
@chainho Thanks for the PR! @dev-jonghoonpark @sunyuhan1998 Thanks for the review. |
spring-builds
pushed a commit
that referenced
this pull request
Jun 6, 2025
* fix:Typo cloud bindings doc Signed-off-by: chainHo <chainhou@gmail.com> (cherry picked from commit 694bb50)
namsoo2
pushed a commit
to namsoo2/spring-ai
that referenced
this pull request
Jun 9, 2025
* fix:Typo cloud bindings doc Auto-cherry-pick to 1.0.x Signed-off-by: chainHo <chainhou@gmail.com> Signed-off-by: minsoo.nam <minsoo.nam@linecorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix clou to cloud in docs