Skip to content

Bump spring boot version in used recipes to 2.7.3 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Bump spring boot version in used recipes to 2.7.3 #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5c7fe3
Bump Spring Boot version to 2.7 in recipes
fabapp2 Sep 19, 2022
cd08e35
Moved Disabled annotation from type to methods as it was ignored by M…
fabapp2 Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/sbm-support-boot/src/main/resources/recipes/initialize-spring-boot-migration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
name: "add managed dependency to Maven"
groupId: org.springframework.boot
artifactId: spring-boot-dependencies
version: 2.6.3
version: 2.7.3
dependencyType: pom
scope: import
description: Add Spring Boot dependency management section to buildfile.
Expand Down
4 changes: 3 additions & 1 deletion components/sbm-support-jee/src/test/java/org/springframework/sbm/jee/web/api/WebXmlTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

import static org.assertj.core.api.Assertions.assertThat;

@Disabled("See #")
public class WebXmlTest {

public static final String GIVEN_SERVLET_NAME = "TheServlet";
Expand All @@ -53,6 +52,7 @@ public class WebXmlTest {
"</web-app>";

@Test
@Disabled("See #416")
void deserializeMovieFunExampleWebXml() {
String webXmlSource = """
<web-app version="3.0" xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd">
Expand Down Expand Up @@ -94,6 +94,7 @@ void deserializeMovieFunExampleWebXml() {
}

@Test
@Disabled("See #416")
void deserializeWebXml() throws IOException, JAXBException {

String expectedXml =
Expand Down Expand Up @@ -124,6 +125,7 @@ void deserializeWebXml() throws IOException, JAXBException {
}

@Test
@Disabled("See #416")
void deleteServletDefinition() throws JAXBException {
String expectedXml =
"<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" +
Expand Down