Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build & publish Docker image using GitHub Workflow #121

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

addianto
Copy link
Contributor

Good day!

I created a new workflow to automate building Docker image and publishing it to Docker Hub.
It is also to resolve issue #93, as I noticed the images on Docker Hub are outdated.

I have tested the new workflow in a separate branch during development.
The successful workflow run log can be found at: https://github.com/addianto/spring-petclinic-rest/actions/runs/6611300030/job/17954895176

Please note that the workflow requires two GitHub Secrets (i.e., DOCKERHUB_USERNAME & DOCKERHUB_TOKEN).
I assume the project's maintainers do have access to the Docker Hub account that publishes the image in order to create the required GitHub Secrets.

@arey
Copy link
Member

arey commented Oct 30, 2023

Thanks @addianto I will try to publish a new Docker image with your new workflow

@arey arey merged commit 6fbb100 into spring-petclinic:master Oct 30, 2023
1 check passed
@addianto
Copy link
Contributor Author

You're welcome, @arey. 🙏 Don't forget to set up the required DOCKERHUB_TOKEN and DOCKERHUB_PASSWORD variables as repository secrets at this repository's settings, i.e. https://github.com/spring-petclinic/spring-petclinic-rest/settings/secrets/actions.

@addianto addianto deleted the enhancement/build-docker-hub branch October 30, 2023 11:38
@arey
Copy link
Member

arey commented Oct 30, 2023

I will switch to on: workflow_dispatch for manual testing

@arey
Copy link
Member

arey commented Oct 30, 2023

The 3.0.2 is available right now: https://hub.docker.com/repository/docker/springcommunity/spring-petclinic-rest/general
I will revert my last commit

@arey
Copy link
Member

arey commented Oct 30, 2023

We could generalize this workflow to all the main repositories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants