ONEUP-6218: github composite nodejs ECS #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querwurzel
reviewed
Dec 23, 2022
querwurzel
reviewed
Dec 23, 2022
querwurzel
reviewed
Dec 23, 2022
querwurzel
reviewed
Dec 27, 2022
querwurzel
reviewed
Dec 27, 2022
querwurzel
reviewed
Dec 27, 2022
querwurzel
reviewed
Dec 27, 2022
| echo "GIT_ACTIONS_URL=<$GIT_REPO_URL/actions/runs/${{ github.run_id }}|${GIT_REPO_NAME#*/}>" >> $GITHUB_ENV | ||
| [[ "$GIT_PR" =~ ^[0-9]+$ ]] && GIT_PR_MSG="<$GIT_PR_URL|$GIT_COMMIT_MSG>" || GIT_PR_MSG="$GIT_COMMIT_MSG" | ||
| echo "GIT_PR_MSG=$GIT_PR_MSG" >> $GITHUB_ENV | ||
| shell: bash |
There was a problem hiding this comment.
Are you fine with moving shell: bash before the bash script? This applies to all steps using shell scripts :)
There was a problem hiding this comment.
Technically none, but in my regards a bit in terms of readability
There was a problem hiding this comment.
maybe difference in thinking, I feel at the end if more readable :D
There was a problem hiding this comment.
at least can find out easily where this is not added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.