removed spring-xd-dirt dependencies - #1
Closed
dturanski wants to merge 4 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
nitpick, but I don't think we need the util namespace for this file
added 2 commits
July 8, 2015 15:34
Contributor
|
squashed and merged as 3218c39 |
sobychacko
added a commit
to sobychacko/spring-cloud-stream
that referenced
this pull request
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes direct dependencies on spring-xd-dirt and provides the minimum classses needed for the tests to pass. Classes copied from dirt are kept in o.s.xd.dirt... to be easily identified. Most of these are in spring-xd-runner. A couple are in spring-cloud-streams to avoid circular dependencies. A modified codec.xml is provided which removes the TupleCodec. This could be added back to support Tuple payloads, currently not used in the tests. This would require a dependency on spring-xd-tuple. Codec config will need to be redone soon anyway. Also, dirt provides a number of ModuleOptionsMetadata classes needed to use common modules that are now missing. Module options is another area to revisit.