Skip to content

Update RetryableFeignBlockingLoadBalancerClient.java #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update RetryableFeignBlockingLoadBalancerClient.java #632

wants to merge 1 commit into from

Conversation

Been24
Copy link
Contributor

@Been24 Been24 commented Nov 25, 2021

fix LogFactory.getLog(Class<?> clazz) wrong class

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Been24 Thanks for submitting the PR. Good catch :). However, I'm going to cherry-pick your commit to 3.0.x so that it also gets included in the 2020.0.x release train.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #632 (49f1e49) into main (65efa29) will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #632      +/-   ##
============================================
+ Coverage     79.02%   79.48%   +0.46%     
- Complexity      536      537       +1     
============================================
  Files            65       65              
  Lines          1955     1955              
  Branches        271      271              
============================================
+ Hits           1545     1554       +9     
+ Misses          261      252       -9     
  Partials        149      149              
Impacted Files Coverage Δ
...ncer/RetryableFeignBlockingLoadBalancerClient.java 71.57% <100.00%> (ø)
...mework/cloud/openfeign/FeignClientFactoryBean.java 77.82% <0.00%> (+3.50%) ⬆️

@OlgaMaciaszek OlgaMaciaszek added bug Something isn't working and removed waiting-for-triage labels Nov 29, 2021
@OlgaMaciaszek OlgaMaciaszek added this to the 3.0.6 milestone Nov 29, 2021
@OlgaMaciaszek
Copy link
Collaborator

Merged within 70a9002.

@Been24 Been24 deleted the patch-1 branch November 30, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants