Skip to content

enable feign.autoconfiguration.jackson.enabled by default in the next major release #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OlgaMaciaszek merged 1 commit into from
Oct 12, 2022
Merged

enable feign.autoconfiguration.jackson.enabled by default in the next major release #476

OlgaMaciaszek merged 1 commit into from
Oct 12, 2022

Conversation

@nkonev
Copy link
Contributor

@nkonev nkonev commented Jan 28, 2021

Fixes #470

@codecov
Copy link

codecov bot commented Jan 28, 2021 •
edited
Loading

Codecov Report

Merging #476 (828a6fa) into main (28345b2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #476   +/-   ##
=========================================
  Coverage     78.99%   78.99%           
  Complexity      539      539           
=========================================
  Files            65       65           
  Lines          2014     2014           
  Branches        275      275           
=========================================
  Hits           1591     1591           
  Misses          264      264           
  Partials        159      159
Impacted Files Coverage Δ
...mework/cloud/openfeign/FeignAutoConfiguration.java 90.14% <ø> (ø)

OlgaMaciaszek
OlgaMaciaszek requested changes Feb 8, 2021
View reviewed changes
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkonev An update should also be added to the docs.

@OlgaMaciaszek OlgaMaciaszek self-assigned this Feb 8, 2021
@nkonev
Copy link
Contributor Author

nkonev commented Feb 8, 2021

@nkonev An update should also be added to the docs.

Do you mean this file https://github.com/spring-cloud/spring-cloud-openfeign/blob/master/docs/src/main/asciidoc/spring-cloud-openfeign.adoc ?

@OlgaMaciaszek
Copy link
Collaborator

OlgaMaciaszek commented Feb 8, 2021

Yes.

@nkonev nkonev requested a review from OlgaMaciaszek February 11, 2021 23:45
OlgaMaciaszek
OlgaMaciaszek approved these changes Feb 16, 2021
View reviewed changes
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged when we branch out the next major.

@OlgaMaciaszek OlgaMaciaszek added enhancement New feature or request and removed waiting for feedback labels Feb 16, 2021
@nkonev nkonev force-pushed the gh-470 branch 2 times, most recently from 3b732ef to 6e07d71 Compare March 12, 2021 13:30
@nkonev nkonev force-pushed the gh-470 branch 2 times, most recently from b7860fd to 59b6fdb Compare January 14, 2022 16:15
@nkonev nkonev requested a review from OlgaMaciaszek January 14, 2022 16:16
@nkonev
Copy link
Contributor Author

nkonev commented Feb 1, 2022

@OlgaMaciaszek v4.0.0-M1 / 2022.0.0-M1 has been released, it seems we can merge this PR

@nkonev
Copy link
Contributor Author

nkonev commented Oct 11, 2022

Hey @OlgaMaciaszek @spencergibb Would you like to add it to the nearest https://github.com/spring-cloud/spring-cloud-release/milestone/114 ?

@spencergibb spencergibb added this to the 4.0.0-RC1 milestone Oct 12, 2022
@OlgaMaciaszek
Copy link
Collaborator

OlgaMaciaszek commented Oct 12, 2022

Yes. It should go in there. Will take care of it today.

OlgaMaciaszek
OlgaMaciaszek approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nkonev . LGTM.

@OlgaMaciaszek OlgaMaciaszek merged commit e1a9b77 into spring-cloud:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlgaMaciaszek OlgaMaciaszek OlgaMaciaszek approved these changes

Assignees

@OlgaMaciaszek OlgaMaciaszek

Labels

enhancement New feature or request

Projects

None yet

Milestone

4.0.0-RC1

Development

Successfully merging this pull request may close these issues.

Enable feign.autoconfiguration.jackson.enabled by default

4 participants

@nkonev @OlgaMaciaszek @spencergibb @spring-cloud-issues