Spring Data Pageable Sort in Feign Client

[sebastian3456]

The new pageable support in version 2.1.1 can't handle the sorting in the pageable.

Here is my code:
@RequestMapping(method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE) Page<T> findAll(@RequestParam("parameters") Map<String, Collection<String>> parameters, @RequestBody Pageable page);

When I call this method size and page parameters are mapped fine, sorting is not working.
Let's expect I have a pageable with a sort on id,asc.
So the request url should look like example.com/api/test?page=0&size=10&sort=id,ASC
But the actual request url looks like example.com/api/test?page=0&size=10&sort=id&sort=ASC

[ryanjbaxter]

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[jbrmg]

@ryanjbaxter I created a sample: https://github.com/jbrmg/openfeign-issue-146 . Please see the class Issue146Test for the executable test code. The test fails as expected.

As stated by @sebastian3456, the problem is that the sort query param is split into two parameters in the request url. This however does not get parsed by other spring boot services. This seems to be caused by the CollectionFormat for the RequestTemplate being CollectionFormat.EXPLODED, which performs a split by , on the original query param set by the PageableQueryEncoder.

[colinzhy]

Also, encounter this issue, any suggestion?

My workaround is extending the PageableSpringEncoder, override the encode method and update the collectionFormat to CollectionFormat.CSV

  @Override
  public void encode(Object object, Type bodyType, RequestTemplate template) throws EncodeException {
    template.collectionFormat(CollectionFormat.CSV);
    super.encode(object, bodyType, template);
  }

Any better solution? I know we can set collectionFormat in @RequestLine , how about to use Spring?

[nciriglianoupgrade]

@sebastian3456 the issue was solved here: OpenFeign/feign#930
please update io.github.openfeign dependencies to a higher version than 10.2.0 (last version with this bug)

[ryanjbaxter]

We updated to OpenFeign 10.4.0 in this fix eecc51e

Please reopen if this did not fix the issue