Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for asynchronous service instance binding and unbinding #127

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

royclarkson
Copy link
Member

Resolves #66

default GetLastServiceBindingOperationResponse getLastOperation(GetLastServiceBindingOperationRequest request) {
throw new UnsupportedOperationException("This service broker does not support getting the status of " +
"an asynchronous operation. " +
"If the service broker returns '202 Accepted' in response to a provision, update, or deprovision" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "... in response to a bind or unbind request ..."

@codecov-io
Copy link

Codecov Report

Merging #127 into 2.x will decrease coverage by 2.74%.
The diff coverage is 83.13%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #127      +/-   ##
============================================
- Coverage     94.51%   91.76%   -2.75%     
+ Complexity      759      757       -2     
============================================
  Files            83       86       +3     
  Lines          1823     1955     +132     
  Branches        195      212      +17     
============================================
+ Hits           1723     1794      +71     
- Misses           72      129      +57     
- Partials         28       32       +4
Impacted Files Coverage Δ Complexity Δ
...vice/NonBindableServiceInstanceBindingService.java 100% <ø> (ø) 4 <0> (ø) ⬇️
.../model/instance/CreateServiceInstanceResponse.java 93.1% <ø> (-3.45%) 13 <0> (-1)
.../model/instance/UpdateServiceInstanceResponse.java 92% <ø> (-4%) 11 <0> (-1)
...cebroker/controller/ServiceInstanceController.java 100% <ø> (ø) 14 <0> (-3) ⬇️
.../model/instance/DeleteServiceInstanceResponse.java 92.3% <ø> (-7.7%) 3 <0> (-1)
...ance/AsyncParameterizedServiceInstanceRequest.java 85.71% <ø> (-4.77%) 12 <0> (-1)
...r/model/instance/DeleteServiceInstanceRequest.java 95.23% <ø> (-2.39%) 16 <0> (-1)
...ebroker/service/ServiceInstanceBindingService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...l/binding/DeleteServiceInstanceBindingRequest.java 95.65% <100%> (-2.08%) 17 <1> (-1)
...ervicebroker/model/AsyncServiceBrokerResponse.java 92.85% <100%> (ø) 11 <2> (?)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346d288...0ff0d06. Read the comment docs.

@royclarkson royclarkson merged commit 113edcf into 2.x Oct 9, 2018
@aclement aclement removed the review label Oct 9, 2018
@royclarkson royclarkson deleted the 66-async-bindings branch October 9, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants