fix: use ',' as delimiter for key-value pairs in labelSelector

[cmaune]

#1899

[ryanjbaxter]

We should add a test to cover this

[ryanjbaxter]

Also could you make the PR against the 3.1.x branch? I will merge it forward

[wind57]

As a matter of fact, the pipeline fails in a unit test :) so just fix that one, and we should be good to go.

I was thinking to change the unit test also, just a tiny bit:

	@Test
	void multipleLabelsLabel() {
		Map<String, String> labels = new LinkedHashMap<>();
		labels.put("a", "b");
		labels.put("c", "d");
		String result = KubernetesCatalogWatchContext.labelSelector(labels);
		Assertions.assertEquals("a=b,c=d", result);
	}

[wind57]

you will have to create the PR from scratch against branch 3.1.x, because otherwise you will bring lots of un-related changes

[cmaune]

@wind57 thx, hopefully this should be fine now.
@ryanjbaxter recreated to point against 3.1.x

And sorry for the inconvenience, i had not cloned the project and did the initial PR just via edit from github ui, so i havnt seen the test.

[wind57]

no worries at all! thank you for the excellent explanation in the bug description and the investigation! I dont have the right to approve the build, but my guess is that Ryan will, in a few hours.

[ryanjbaxter]

There are a couple of other tests that need to be updated
https://github.com/spring-cloud/spring-cloud-kubernetes/actions/runs/14103226028/job/39514798090?pr=1900#step:8:8802

[cmaune]

Updated the fix for the failed tests in last run, if there are still some more, ill come back later on when i got spare time and have setup the project locally to build and run all tests locally