Add Maven profile for Vault integration #1868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjbaxter
reviewed
Feb 9, 2025
| you will need to include the namespace in which the Config Server is deployed in order to continue to fetch Config Map and Secret data from that namespace. | ||
|
|
||
| ### Vault Integration | ||
| To enable Vault integration, you can activate the vault Maven profile by setting the `useVault` property to true. This profile adds the `spring-vault-core` dependency. |
There was a problem hiding this comment.
I don't think we need to use a flag we can just enable the profile. This is how I would suggest we write this.
Using Advanced Features Of Spring Vault
In order to use some of the more advanced Spring Vault features of the Spring Cloud Config Server, spring-vault-core must be on the classpath. By default Spring Cloud Kubernetes can build a Docker image to deploy the Config Server to Kuberentes but it does not add spring-core-vault to the classpath. If you need spring-core-vault on the classpath to enable certain functionality in the Config Server you can build your own version of the Docker image by enabling the vault Maven profile when running the Maven build.
[source,bash]
$ ../../mvnw clean instal -Pvault
There was a problem hiding this comment.
Updated, Please check.
Signed-off-by: Arjav <arjavdongaonkar@gmail.com>
Signed-off-by: Arjav <arjavdongaonkar@gmail.com>
Signed-off-by: Arjav <arjavdongaonkar@gmail.com>
arjavdongaonkar
force-pushed
the
chore/add-spring-vault-core
branch
from
3fa95fd to
100c15b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useVaultwhich adds Spring Vault Core dependency to enable Vault integration in the Spring Cloud Kubernetes Config Server.