Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close Fabric8 Client When Context Is Stopped #1780

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Close Fabric8 Client When Context Is Stopped #1780

merged 2 commits into from
Oct 23, 2024

Conversation

ryanjbaxter
Copy link
Contributor

No description provided.

@ryanjbaxter ryanjbaxter force-pushed the closable-fabric8-client branch from 6253909 to febbe07 Compare October 23, 2024 12:06
@ryanjbaxter ryanjbaxter force-pushed the closable-fabric8-client branch from febbe07 to 0adfd8d Compare October 23, 2024 12:10
@ryanjbaxter
Copy link
Contributor Author

@wind57 thanks. I am still not really happy with this. Since KubernetesClient implements AutoClosable it seems like the close method should be called automatically. Maybe the timing in which that happens is too late 🤷‍♂️.

@wind57
Copy link
Contributor

wind57 commented Oct 23, 2024

@ryanjbaxter the build is going to fail, the cache download to blame... you might want to push a dummy commit to re-trigger

@ryanjbaxter ryanjbaxter changed the title close fabric 8 client Close Fabric8 Client When Context Is Stopped Oct 23, 2024
@ryanjbaxter ryanjbaxter added this to the 3.1.4 milestone Oct 23, 2024
@ryanjbaxter ryanjbaxter merged commit c6429b3 into spring-cloud:main Oct 23, 2024
14 checks passed
ryanjbaxter pushed a commit that referenced this pull request Oct 23, 2024
@ryanjbaxter
Close Fabric8 Client When Context Is Stopped (#1780)
4d55f69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wind57 wind57 wind57 left review comments

Assignees
No one assigned
Labels
bug
Projects
No open projects
2023.0.4
Status: Done
2024.0.0-RC1
Status: Done
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanjbaxter @wind57 @spring-cloud-issues