Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace fabric8 serialization calls (4) #1423

Merged
merged 3 commits into from
Sep 1, 2023
Merged

replace fabric8 serialization calls (4) #1423

merged 3 commits into from
Sep 1, 2023

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Aug 27, 2023

No description provided.

@wind57 wind57 changed the title fix replace fabric8 serialization calls Aug 27, 2023
@wind57 wind57 changed the title replace fabric8 serialization calls replace fabric8 serialization calls (4) Aug 27, 2023
@wind57
Copy link
Contributor Author

wind57 commented Aug 31, 2023

we had a bug recently where serialization was changed in fabric8 and our builds started failing in main. When I looked at the underlying issue in fabric8 repo, one of the suggestions was to move to Serialization class and this is exactly what this PR does. It only touches those integration tests.

@wind57 wind57 marked this pull request as ready for review September 1, 2023 01:37
@wind57
Copy link
Contributor Author

wind57 commented Sep 1, 2023

@ryanjbaxter one more fairly easy to review. thank you

@ryanjbaxter ryanjbaxter added this to the 3.0.5 milestone Sep 1, 2023
@ryanjbaxter ryanjbaxter merged commit 8edeee0 into spring-cloud:3.0.x Sep 1, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
No open projects
2022.0.5
Status: Done
2023.0.0-M2
Status: Done
Milestone
3.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@wind57 @ryanjbaxter @spring-cloud-issues