Correct tests after fabric8 upgrade #1374
Conversation
Configure Renovate
| @@ -57,7 +57,7 @@ void locateShouldThrowExceptionOnFailureWhenFailFastIsEnabled() { | |||
| configMapConfigProperties, new KubernetesNamespaceProvider(new MockEnvironment())); | |||
|
|
|||
| assertThatThrownBy(() -> locator.locate(new MockEnvironment())).isInstanceOf(IllegalStateException.class) | |||
| .hasMessageContaining("api/v1/namespaces/default/configmaps. Message: Not Found."); | |||
There was a problem hiding this comment.
this has caught my eye while looking at the PR that you created Ryan with fabric8 upgrade. I am not very sure what was going on and where, but "Not Found" message should have not happened, as we have a stub with "Internal Server Error" right before that, that we assert for it, on purpose.
There was a problem hiding this comment.
I think that the problem was in our tests all this time, but with the new upgrade they all "came to life". Most probably fabric8 tightened the internal implementation. The missing bit for me right now is how this passes locally...
There was a problem hiding this comment.
Ah i thought they had changed the message
There was a problem hiding this comment.
yeah, I remember facing the same issue a while ago, that's why it caught my eye
wind57
changed the title
| @@ -48,7 +48,7 @@ void locateShouldThrowExceptionOnFailureWhenFailFastIsEnabled() { | |||
| String namespace = "default"; | |||
| String path = "/api/v1/namespaces/default/configmaps"; | |||
|
|
|||
| mockServer.expect().withPath(path).andReturn(500, "Internal Server Error").once(); | |||
| mockServer.expect().withPath(path).andReturn(500, "Internal Server Error").always(); | |||
There was a problem hiding this comment.
imho, it's a bug somewhere in fabric8 that once does not work here, for the time being always fixes it, though I might dig deeper and raise an issue in fabric8
No description provided.