fix: improve media type comparison for streaming responses #3948#3969
Open
jerolba wants to merge 1 commit intospring-cloud:4.3.xfrom
Open
fix: improve media type comparison for streaming responses #3948#3969jerolba wants to merge 1 commit intospring-cloud:4.3.xfrom
jerolba wants to merge 1 commit intospring-cloud:4.3.xfrom
Conversation
Replace List.contains() with equalsTypeAndSubtype() for more accurate media type matching, avoiding issues with media type parameters. Signed-off-by: jerolba <jerolba@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3948
Improves the media type comparison logic for determining when to use streaming response handling by implementing proper type and subtype matching instead of relying on exact media type equality.
This fix addresses scenarios where streaming responses include charset or other parameters in their Content-Type headers, ensuring they are properly handled with the streaming copy mechanism that includes appropriate flushing.
Problem
The previous implementation used
List.contains()to check if a response's content type matches any of the configured streaming media types. This approach failed when the actual media type included parameters (e.g., text/event-stream;charset=UTF-8) because it relied on exact MediaType object equality rather than semantic type/subtype matching.Solution
isStreamingMediaType()helper methodMediaType.equalsTypeAndSubtype()