Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway actuator endpoints available on server.port when specific management port used #153

Closed
mathieufortin01 opened this issue Jan 12, 2018 · 3 comments
Labels
Milestone

Comments

@mathieufortin01
Copy link
Contributor

Using:

  • Spring Boot 2.0.0M7
  • Spring Gateway 2.0.0M5
  • server.port = 80
  • management.server.port = 90

The default actuator endpoints are deployed on port 90 (/actuator/health), but the gateway endpoints are only available on port 80 (/application/gateway/routes).

@spencergibb
Copy link
Member

I believe this as already fixed, but I will double check and add a test to verify if there isn't already

@spencergibb
Copy link
Member

The path is fixed, but it is not on the actuator port. :-(

@spencergibb
Copy link
Member

Depends on spring-projects/spring-boot#10257

@spencergibb spencergibb added this to the 2.0.0.M6 milestone Jan 18, 2018
spencergibb added a commit that referenced this issue Jan 18, 2018
Johnny850807 pushed a commit to Johnny850807/spring-cloud-gateway that referenced this issue Dec 14, 2020
Only one neds to be created, and once it is in place in the hierarchy
it should be usable by all the child contexts that get added.

Fixes spring-cloudgh-153
Johnny850807 pushed a commit to Johnny850807/spring-cloud-gateway that referenced this issue Dec 14, 2020
The fix for spring-cloudgh-153 was sensible, but has now exposed another issue
which is that the bootstrap initializers, whilst they are now only
created once, actually only get applied to the parent context
in a hierarchy.

Most of the time this doesn't matter because the child contexts all
benefit from environment changes and additional beans added
to the parent. If the children are supposed to actually have
different environments, though, there is a problem. So this change
locates the existing bootstrap context and applies it to each
new context created separately.

Unfortunately we have to use reflection to do that for now because
there is no way to discover the parent with a public API before
the context is refreshed.

See spring-cloudgh-190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants