Override logback version to 1.2.13 #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Dec 7, 2023
| @@ -87,13 +88,6 @@ | |||
| <type>pom</type> | |||
| <scope>import</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Since our parent is SBD, having the direct import of SBD does nothing other than removes the ability to do easy version overrides such as https://github.com/spring-cloud/spring-cloud-dataflow/pull/5595/files#diff-7059f95906ccc5bf99ecd1a8702cabced0dc3f24f787c8d32281c624e4f33943R42.
onobc
commented
Dec 7, 2023
| @@ -113,6 +114,22 @@ | |||
| <artifactId>spring-security-oauth2-client</artifactId> | |||
| <version>${spring-security.version}</version> | |||
| </dependency> | |||
| <!-- Override Logback provided by Spring Boot --> | |||
There was a problem hiding this comment.
Because we do NOT inherit from SBD all we have to do is declare the dep. mgmt. above the SBD dep. mgmt (background).
onobc
commented
Dec 7, 2023
| @@ -39,6 +39,7 @@ | |||
| <kubernetes-fabric8-client.version>5.12.4</kubernetes-fabric8-client.version> | |||
| <junit.version>4.13.1</junit.version> | |||
| <junit-jupiter.version>5.9.2</junit-jupiter.version> | |||
| <logback.version>1.3.14</logback.version> | |||
There was a problem hiding this comment.
Now that I have removed the direct import of SBD, we can simply override the version (background).
This commit overrides the logback version in order to fix CVE-2023-6378. See spring-cloud#5593
onobc
force-pushed
the
GH-5593-logback-cve-fix
branch
from
5964c5e to
cc17eb3
Compare
onobc
changed the title
corneil
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit overrides the logback version in order to fix CVE-2023-6378.
See #5593
Before changes
After changes