Skip to content

Conversation

@marcingrzejszczak
Copy link
Contributor

No description provided.

Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
@OlgaMaciaszek OlgaMaciaszek moved this to In Progress in 2025.1.0-M3 Oct 1, 2025
@OlgaMaciaszek OlgaMaciaszek added this to the 5.0.0-M3 milestone Oct 1, 2025
@OlgaMaciaszek OlgaMaciaszek merged commit 51a74e4 into spring-cloud:main Oct 1, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2025.1.0-M3 Oct 1, 2025
@marcingrzejszczak marcingrzejszczak deleted the propertiesChange branch October 2, 2025 09:56
@timtebeek
Copy link

hi @marcingrzejszczak ; hope you're well! Elsewhere for property migrations we've seen deprecation entries added as seen here:

    {
      "name": "logging.file.clean-history-on-start",
      "type": "java.lang.Boolean",
      "description": "Whether to clean the archive log files on startup. Only supported with the default logback setup.",
      "sourceType": "org.springframework.boot.context.logging.LoggingApplicationListener",
      "defaultValue": false,
      "deprecation": {
        "replacement": "logging.logback.rollingpolicy.clean-history-on-start",
        "since": "2.4.0"
      }
    },

Would it be possible to back fill those in https://github.com/spring-cloud/spring-cloud-contract/blob/v5.0.1/spring-cloud-contract-stub-runner/src/main/resources/META-INF/additional-spring-configuration-metadata.json ?

That way Spring Tools users will get notified about the suggested replacements, as well as other tools using that metadata. 😇

@marcingrzejszczak
Copy link
Contributor Author

That's a great idea. Sorry I haven't thought of that 🤦

marcingrzejszczak added a commit to marcingrzejszczak/spring-cloud-contract that referenced this pull request Jan 6, 2026
@marcingrzejszczak
Copy link
Contributor Author

There you go #2398

marcingrzejszczak added a commit to marcingrzejszczak/spring-cloud-contract that referenced this pull request Jan 6, 2026
related to spring-cloudgh-2309

Signed-off-by: marcin <marcin.grzejszczak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants