Relaxed SSL validation with RestTemplate interceptors #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| factory.setHttpClient(createSslHttpClient()); | ||
| } | ||
| else if (restTemplate.getRequestFactory() instanceof InterceptingClientHttpRequestFactory) { |
There was a problem hiding this comment.
Is there any other way rather than doing this via reflection? Maybe we should ask the Spring team for relaxing some constraints there if there's no other way?
There was a problem hiding this comment.
I was not able to find better way. I will create ticket in Spring framework
|
Can you please fix checkstyle issues in the meantime? |
|
Sorry didn't have time, will do it today. |
|
done, sorry for delay. |
marcingrzejszczak
approved these changes
Mar 21, 2023
|
Thanks @nkolosnjaji ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1868