Repository navigation
Fix path segment API versioning in blocking LoadBalancer - #1759
Open
NotAFlightRisk wants to merge 1 commit into
Open
NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
Signed-off-by: Iain <iain1970@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path segment API versioning doesn't work with a
@LoadBalancedRestClientorRestTemplate, it falls over before an instance even gets picked. The servletPathApiVersionResolveronly reads a path that DispatcherServlet has already parsed and stored on the request, and the stand-in request built for those calls doesn't have one, so you getIllegalArgumentException: Expected parsed RequestPath in request attribute "org.springframework.web.util.ServletRequestPathUtils.PATH".This parses it from the URL with no context path, like the WebClient side does. A parsed path that's already in the attributes still wins - Gateway's MVC load balancer filter passes the incomming request's attributes through, so that one has the real context path in it.
I've not run Gateway itself, just a throwaway test giving the supplier a path parsed with a
/ctxcontext path.