-
Notifications
You must be signed in to change notification settings - Fork 716
feat(lb): deterministic subsetting algorithm #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9472b6f
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi 22e212a
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi 48bbf98
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi 6ff2aa7
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi 9935bc5
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi 31bb1b9
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi d0308cd
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi 75d4691
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi 6ac12e2
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi d15c668
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi 292abce
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi f488bed
feat(lb): deterministic subsetting algorithm to limit the number of i…
jizhuozhi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 93 additions & 0 deletions
93
...n/java/org/springframework/cloud/loadbalancer/core/SubsetServiceInstanceListSupplier.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
/* | ||
* Copyright 2012-2023 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.cloud.loadbalancer.core; | ||
|
||
import java.util.ArrayList; | ||
import java.util.Collections; | ||
import java.util.List; | ||
import java.util.Random; | ||
|
||
import reactor.core.publisher.Flux; | ||
|
||
import org.springframework.cloud.client.ServiceInstance; | ||
import org.springframework.cloud.client.loadbalancer.LoadBalancerProperties; | ||
import org.springframework.cloud.client.loadbalancer.reactive.ReactiveLoadBalancer; | ||
import org.springframework.cloud.commons.util.IdUtils; | ||
import org.springframework.core.env.PropertyResolver; | ||
import org.springframework.util.StringUtils; | ||
|
||
/** | ||
* A {@link ServiceInstanceListSupplier} implementation that uses | ||
* <a href="https://sre.google/sre-book/load-balancing-datacenter/">deterministic | ||
* subsetting algorithm</a> to limit the number of instances provided by delegate. | ||
* | ||
* @author Zhuozhi Ji | ||
* @since 4.1.0 | ||
*/ | ||
jizhuozhi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public class SubsetServiceInstanceListSupplier extends DelegatingServiceInstanceListSupplier { | ||
|
||
private final String instanceId; | ||
|
||
private final int size; | ||
|
||
public SubsetServiceInstanceListSupplier(ServiceInstanceListSupplier delegate, PropertyResolver resolver, | ||
ReactiveLoadBalancer.Factory<ServiceInstance> factory) { | ||
super(delegate); | ||
LoadBalancerProperties properties = factory.getProperties(getServiceId()); | ||
this.instanceId = resolveInstanceId(properties, resolver); | ||
this.size = properties.getSubset().getSize(); | ||
} | ||
|
||
@Override | ||
public Flux<List<ServiceInstance>> get() { | ||
jizhuozhi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return delegate.get().map(instances -> { | ||
if (instances.size() <= size) { | ||
return instances; | ||
} | ||
|
||
instances = new ArrayList<>(instances); | ||
|
||
int instanceId = this.instanceId.hashCode() & Integer.MAX_VALUE; | ||
int count = instances.size() / size; | ||
int round = instanceId / count; | ||
|
||
Random random = new Random(round); | ||
Collections.shuffle(instances, random); | ||
|
||
int bucket = instanceId % count; | ||
int start = bucket * size; | ||
return instances.subList(start, start + size); | ||
}); | ||
} | ||
|
||
private static String resolveInstanceId(LoadBalancerProperties properties, PropertyResolver resolver) { | ||
String instanceId = properties.getSubset().getInstanceId(); | ||
if (StringUtils.hasText(instanceId)) { | ||
return resolver.resolvePlaceholders(properties.getSubset().getInstanceId()); | ||
} | ||
return IdUtils.getDefaultInstanceId(resolver); | ||
} | ||
|
||
public String getInstanceId() { | ||
return instanceId; | ||
} | ||
|
||
public int getSize() { | ||
return size; | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.