Skip to content

commonsFeatures method name updated to springCloudCommonsFeatures. #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2023
Merged

commonsFeatures method name updated to springCloudCommonsFeatures. #1230

merged 1 commit into from
May 1, 2023

Conversation

omernaci
Copy link
Contributor

@omernaci omernaci commented May 1, 2023 •
edited
Loading

Fixes #1229 | @ryanjbaxter I have updated it as you suggested. I also saw that bean was formed successfully with CommonsClientAutoConfigurationTests :

org.springframework.beans.factory.support.DefaultListableBeanFactory -- Creating shared instance of singleton bean 'springCloudCommonsFeatures'

@omernaci omernaci changed the title commonsFeatures method name updated to springCloudCommonsFeatures. Fixes #1229 commonsFeatures method name updated to springCloudCommonsFeatures. May 1, 2023
@ryanjbaxter ryanjbaxter merged commit 81314d5 into spring-cloud:main May 1, 2023
@ryanjbaxter
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bean name "commonFeatures" could have a better naming
3 participants
@omernaci @ryanjbaxter @spring-cloud-issues