Skip to content

Commit

Permalink
Merge pull request #218 from ryanjbaxter/duplicate-metrics
Browse files Browse the repository at this point in the history
Add autoconfigureafter annotation to avoid duplicate metrics
  • Loading branch information
ryanjbaxter authored Oct 16, 2024
2 parents 39609c3 + 854e1f1 commit 9d48c8c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/maven.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ name: Build

on:
push:
branches: [ main, 3.0.x, 2.1.x ]
branches: [ main, 3.1.x, 3.0.x, 2.1.x ]
pull_request:
branches: [ main, 3.0.x, 2.1.x ]
branches: [ main, 3.1.x, 3.0.x, 2.1.x ]

jobs:
build:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import io.github.resilience4j.micrometer.tagged.TaggedCircuitBreakerMetrics;
import io.github.resilience4j.micrometer.tagged.TaggedCircuitBreakerMetricsPublisher;
import io.github.resilience4j.micrometer.tagged.TaggedThreadPoolBulkheadMetrics;
import io.github.resilience4j.springboot3.circuitbreaker.autoconfigure.CircuitBreakerMetricsAutoConfiguration;
import io.github.resilience4j.timelimiter.TimeLimiterRegistry;
import io.micrometer.core.instrument.Meter;
import io.micrometer.core.instrument.MeterRegistry;
Expand All @@ -36,6 +37,7 @@
import jakarta.annotation.PostConstruct;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
Expand All @@ -55,6 +57,7 @@
@EnableConfigurationProperties(Resilience4JConfigurationProperties.class)
@ConditionalOnProperty(name = { "spring.cloud.circuitbreaker.resilience4j.enabled",
"spring.cloud.circuitbreaker.resilience4j.blocking.enabled" }, matchIfMissing = true)
@AutoConfigureAfter(CircuitBreakerMetricsAutoConfiguration.class)
public class Resilience4JAutoConfiguration {

@Autowired(required = false)
Expand Down

0 comments on commit 9d48c8c

Please sign in to comment.