-
Notifications
You must be signed in to change notification settings - Fork 689
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1357 +/- ##
============================================
+ Coverage 67.86% 67.87% +<.01%
- Complexity 1399 1401 +2
============================================
Files 203 203
Lines 5654 5668 +14
Branches 565 565
============================================
+ Hits 3837 3847 +10
- Misses 1585 1589 +4
Partials 232 232
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also link to Spring Kotlin refdocs? Thanks!
docs/src/main/asciidoc/kotlin.adoc
Outdated
@@ -0,0 +1,23 @@ | |||
== Kotlin Support | |||
|
|||
Spring Cloud GCP libraries work out-of-the-box and are fully interoperable with Kotlin Spring boot applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring Cloud GCP libraries work out-of-the-box and are fully interoperable with Kotlin Spring boot applications. | |
Spring Cloud GCP libraries work out-of-the-box and are fully interoperable with Kotlin Spring Boot applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Also created a PR to link back to our kotlin sample from Spring official doc: spring-projects/spring-framework#2070
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a phrasing question.
docs/src/main/asciidoc/kotlin.adoc
Outdated
Depending on your application's needs, you may need to augment your build configuration with compiler plugins: | ||
|
||
* https://kotlinlang.org/docs/reference/compiler-plugins.html#spring-support[Spring Kotlin Plugin]: Makes your Spring configuration classes/members non-final for convenience. | ||
* https://kotlinlang.org/docs/reference/compiler-plugins.html#jpa-support[Kotlin Spring JPA Plugin]: Enables using JPA in Kotlin Spring applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we standardize "Spring Kotlin" vs "Kotlin Spring" for consistency? Grammatically, I think, it makes no difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According the mentioned doc in the link, it doesn't sound like this JPA plugin requires Spring at all.
So, it isn't going to be legitimate to call it Kotlin Spring JPA
at all.
As for the applications concern, I would just call it like Kotlin applications
, not mentioning Spring. From one side Spring might be assumed (just from the context of the current doc), from another side no one said that Spring is mandatory when you build Kotlin applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
@elefeint - Moved to Kotlin Spring for consistency; it appears the spring docs refer to the plugin as "kotlin-spring" so I will standardize around that.
@artembilan - Renamed to Kotlin JPA plugin to be more accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Adds section in refdoc describing kotlin support. Contributes to #1323.
Adds section in refdoc describing kotlin support. Contributes to #1323.
This adds a section in the refdoc discussing Kotlin support. Spring Cloud GCP libraries should work out-of-the-box so long as the user's Kotlin project setup is correct.
Making kotlin app more discoverable #1323