Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Add aws s3:// uri support #565

Closed
wants to merge 16 commits into from
Closed

Add aws s3:// uri support #565

wants to merge 16 commits into from

Conversation

tmnuwan12
Copy link
Contributor

Fixes gh-361

maciejwalkowiak
maciejwalkowiak suggested changes Jun 6, 2020
View reviewed changes
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilation issues is a result of Spring Boot just recently dropping JUnit 4. I'll add very soon JUnit 4 to dependencies both on master and 2.2.x branches so make sure to rebase.

...d-aws-core/src/main/java/org/springframework/cloud/aws/core/io/s3/SimpleStorageResource.java Outdated Show resolved Hide resolved
...d-aws-core/src/main/java/org/springframework/cloud/aws/core/io/s3/SimpleStorageResource.java Outdated Show resolved Hide resolved
@maciejwalkowiak maciejwalkowiak mentioned this pull request Jun 6, 2020
Closed
maciejwalkowiak and others added 14 commits June 7, 2020 17:07
@maciejwalkowiak @tmnuwan12
Add option to use default AWS region provider chain.
a066008 
Fixes spring-atticgh-553
Fixes spring-atticgh-120
Closes spring-atticgh-559
Closes spring-atticgh-560
@cschroedl-gov @maciejwalkowiak @tmnuwan12
Add logging to AWSParameterStorePropertySource.
4d1e776 
Closes spring-atticgh-529
Fixes spring-atticgh-509
Fixes spring-atticgh-527

Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
@maciejwalkowiak @tmnuwan12
Update documentation on how to hide warning message logged by AWS SDK…
02eb1b2 
… on application startup.

Fixes spring-atticgh-556
@tmnuwan12
Fix typo in the exception text
6d189da 
Fixes spring-atticgh-519
Closes spring-atticgh-561
@maciejwalkowiak @tmnuwan12
Bump AWS Java SDK dependency version to 1.11.792.
afbb548 
Fixes spring-atticgh-482
@maciejwalkowiak @tmnuwan12
Update reference documentation on how to upgrade AWS SDK dependency.
ba9373d
@tmnuwan12
Fix S3 object key encoding in SimpleStorageResource.getURL.
79d84db 
Fixes spring-atticgh-483
Closes spring-atticgh-562
@sayembd @maciejwalkowiak @tmnuwan12
Fix duplicate error logging when processing exception thrown in SQS l…
a5b295f 
…istener.

This commit fixes this issue by delegating exception processing to
AbstractMethodMessageHandler only when there is a configured handler.
If there is none, exception is logged.

Fixes spring-atticgh-394
Closes spring-atticgh-465

Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
@cbm-afoulfoin @tmnuwan12
Allow to specify PropertySource name returned by AwsSecretsManagerPro…
e5c15d6 
…pertySourceLocator.

Fixes spring-atticgh-472
Closes spring-atticgh-473
@maciejwalkowiak @tmnuwan12
Add a dependency to JUnit 4.
5ebbc10 
Spring Boot 2.4 has moved from providing automatic support for JUnit 4.
For now we must declare it explicitly and in the future migrate to JUnit 5.
@maciejwalkowiak @tmnuwan12
Document default credentials chain for auto-configuration.
b035b75 
Fixes spring-atticgh-470
@maciejwalkowiak @tmnuwan12
Add CloudWatch integration documentation to the reference.
3a0e9ee 
Fixes spring-atticgh-402
@tmnuwan12
Add aws s3:// uri support
627a2c2 
Fixes spring-atticgh-361
@tmnuwan12
Add code improvements
e8f515f 
Fixes spring-atticgh-361
@tmnuwan12 tmnuwan12 requested a review from maciejwalkowiak June 7, 2020 16:06
@tmnuwan12
Copy link
Contributor Author

Compilation issues is a result of Spring Boot just recently dropping JUnit 4. I'll add very soon JUnit 4 to dependencies both on master and 2.2.x branches so make sure to rebase.

I have rebased against master.

@maciejwalkowiak maciejwalkowiak added status: in-progress An issue that being worked on and removed waiting-for-triage labels Jun 7, 2020
maciejwalkowiak pushed a commit that referenced this pull request Jun 7, 2020
@tmnuwan12 @maciejwalkowiak
Add a method to get S3 URI from a SimpleStorageResource.
762a73c 
Fixes gh-361
Closes gh-565
@maciejwalkowiak
Copy link
Contributor

Thanks @tmnuwan12! Your contribution has been merged.

@maciejwalkowiak maciejwalkowiak removed the status: in-progress An issue that being worked on label Jun 7, 2020
maciejwalkowiak pushed a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request Oct 15, 2020
@tmnuwan12 @maciejwalkowiak
Add a method to get S3 URI from a SimpleStorageResource.
4123710 
Fixes spring-atticgh-361
Closes spring-atticgh-565
maciejwalkowiak pushed a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request Oct 15, 2020
@tmnuwan12 @maciejwalkowiak
Add a method to get S3 URI from a SimpleStorageResource.
1d0b6fa 
Fixes spring-atticgh-361
Closes spring-atticgh-565
maciejwalkowiak pushed a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request Oct 15, 2020
@tmnuwan12 @maciejwalkowiak
Add a method to get S3 URI from a SimpleStorageResource.
974a227 
Fixes spring-attic#361
Closes spring-attic#565
maciejwalkowiak pushed a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request Oct 15, 2020
@tmnuwan12 @maciejwalkowiak
Add a method to get S3 URI from a SimpleStorageResource.
c27aeec 
Fixes spring-attic#361
Closes spring-attic#565
juho9000 pushed a commit to juho9000/spring-cloud-aws that referenced this pull request Apr 29, 2021
@tmnuwan12 @maciejwalkowiak
Add a method to get S3 URI from a SimpleStorageResource.
c252e77 
Fixes spring-attic/spring-cloud-aws#361
Closes spring-attic/spring-cloud-aws#565
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to get s3:// URI back from an S3 resource
6 participants
@tmnuwan12 @maciejwalkowiak @spring-projects-issues @cschroedl-gov @sayembd @cbm-afoulfoin