Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Coerce the absence of body into the empty body #28

Merged
merged 2 commits into from
Mar 3, 2016

Conversation

WonderCsabo
Copy link
Contributor

Fixes #25.

@royclarkson
Copy link
Contributor

@WonderCsabo thanks for the PR. I'm hoping to have time over the upcoming holidays to work on this and do some testing. If you can add a few tests, that would be a big help. I'll plan on pushing out a 2.0.0.M4 or RC1 with this change, and you can use that to validate against your code.

@WonderCsabo
Copy link
Contributor Author

Thanks for the feedback. Can you point me to some example tests for request factories? I already tested this against my code BTW.

@WonderCsabo
Copy link
Contributor Author

@royclarkson I added a test. This fails before my fix and passes with may fix. The failure is exactly the same which i experienced in my real app.

@royclarkson
Copy link
Contributor

Excellent. Thanks again for the help.

@WonderCsabo
Copy link
Contributor Author

Any chance to check this out @royclarkson?

@ollide
Copy link

ollide commented Feb 15, 2016

Any update on this? A 2.0.0.M4 release containing the fix would be really nice 👍

royclarkson added a commit that referenced this pull request Mar 3, 2016
Coerce the absence of body into the empty body
@royclarkson royclarkson merged commit e84ceea into spring-attic:master Mar 3, 2016
@WonderCsabo WonderCsabo deleted the fix-25 branch March 3, 2016 22:16
@WonderCsabo
Copy link
Contributor Author

@royclarkson thanks for merging this finally. ☺️

@royclarkson
Copy link
Contributor

I know. :( too much going on. I'm pushing out a 2.0.0.M4 to get this in a release. We can figure out the OkHttp3 stuff in #29.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants